Nominating @vmarchaud as JavaScript approver #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
Thank you for all the contributions @vmarchaud. I think this meets the requirements for approver.
|
@bhs @yurishkuro @SergeyKanzhelev can at least one of you also approve this? |
bhs
approved these changes
Sep 12, 2019
|
@bhs thanks for the merge. @vmarchaud is still not part of https://github.com/orgs/open-telemetry/teams/node-approvers list. |
|
@mayurkale22 and esp @vmarchaud : apologies about that – fixed. |
|
I've just added to the team, where did you add vmarchaud to @bhs? |
|
@bogdandrutu I added to the
|
|
Yep it's working now, thanks @bhs @bogdandrutu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of contributions to the OpenTelemetry project